[Spice-devel] [PATCH 16/24] mingw32 build: check for CXImage, disable if not found (only on mingw32)

[Alon Levy]

On Wed, Dec 08, 2010 at 09:43:47AM +0100, Hans de Goede wrote:
> Hi,
> 
> On 12/07/2010 10:28 PM, Alon Levy wrote:
> >---
> >  client/windows/Makefile.am  |    1 +
> >  client/windows/platform.cpp |   16 ++++++++++++++++
> >  configure.ac                |   21 +++++++++++++++++++++
> >  3 files changed, 38 insertions(+), 0 deletions(-)
> >
> >diff --git a/client/windows/Makefile.am b/client/windows/Makefile.am
> >index f673afd..29c30a7 100644
> >--- a/client/windows/Makefile.am
> >+++ b/client/windows/Makefile.am
> >@@ -21,6 +21,7 @@ INCLUDES = \
> >  	$(CEGUI_CFLAGS)					\
> >  	$(WARN_CFLAGS)                                  \
> >  	$(SPICE_NONPKGCONFIG_CFLAGS)			\
> >+	$(CXIMAGE_CFLAGS)               \
> >  	$(NULL)
> >
> >
> >diff --git a/client/windows/platform.cpp b/client/windows/platform.cpp
> >index 3eb2cf6..465bb2f 100644
> >--- a/client/windows/platform.cpp
> >+++ b/client/windows/platform.cpp
> >@@ -32,7 +32,15 @@
> >  #include "playback.h"
> >  #include "cursor.h"
> >  #include "named_pipe.h"
> >+
> >+#define USE_CXIMAGE
> >+
> 
> Why not simply:
> 
> #ifndef DISABLE_CXIMAGE
> #define USE_CXIMAGE
> #endif
> 
> ?
> 

Yes.. that is better.

> <snip>
> 
> Regards,
> 
> Hans