[Spice-devel] [PATCH] spice-protocl: add SPICE_MSG_DISPLAY_SURFACE_CREATE/DESTROY

[Alexander Larsson]

On Fri, 2010-02-19 at 16:49 +0200, Izik Eidus wrote:
> On Fri, 19 Feb 2010 14:19:29 +0100
> Alexander Larsson <alexl at redhat.com> wrote:
> 
> > >  enum {
> > > -    SPICE_MSG_DISPLAY_MODE = SPICE_MSG_FIRST_AVAIL,
> > > -    SPICE_MSG_DISPLAY_MARK,
> > > +    SPICE_MSG_DISPLAY_MARK = SPICE_MSG_FIRST_AVAIL,
> > >      SPICE_MSG_DISPLAY_RESET,
> > >      SPICE_MSG_DISPLAY_COPY_BITS,
> > 
> > Is this really necessary? It shifts the value of all the other
> messages,
> > which makes backwards compat unnecessarily complex. Can't we just
> leave
> > the old value unused?
> 
> 
> While I was aware of this, I thought that it isnt the end of the
> world,
> 
> I dont mind keeping it around as unused value, we can probably kick it
> later.

Yeah, leave it for now

> > 
> > Do you really need for the surface to have a specific stride? What
> does
> > the server care what the stride is on the client?
> 
> 
> This would always be (as for now) width == stride,
> But as we dont know how the future will lead us with what kind of
> requiments
> is it really that bad to give stride as well?
> 
> (I really have no strong feeling to drop it,
>  so if you still want, i will drop it)

Well, forcing the client to pick a particular stride might cause it to
run more inefficient (bad alignment, hw restrictions, etc). And i see no
reason for the server to care what alignment the client picks.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
       alexl at redhat.com            alexander.larsson at gmail.com 
He's an ungodly coffee-fuelled messiah moving from town to town, helping folk 
in trouble. She's a high-kicking snooty barmaid prone to fits of savage, 
blood-crazed rage. They fight crime!