[Spice-devel] [PATCH 16/30] Convert cairo canvas alpha_blend to using pixman

Alexander Larsson alexl at redhat.com
Fri Feb 19 07:36:32 PST 2010


On Fri, 2010-02-19 at 17:04 +0200, Izik Eidus wrote:
> On Fri, 19 Feb 2010 10:15:14 +0100
> Alexander Larsson <alexl at redhat.com> wrote:
> 
> > On Fri, 2010-02-19 at 10:47 +0200, Izik Eidus wrote:
> > > On Thu, 18 Feb 2010 21:58:42 +0100
> > > Alexander Larsson <alexl at redhat.com> wrote:
> > > 
> > > 
> > > > +
> > > > +    if (mask)
> > > > +        pixman_image_unref (mask);
> > > > 
> > > 
> > > Any strong feelings against changing it to
> > > if (mask) {
> > >      pixman_image_unref (mask);
> > > }
> > 
> > Nah, thats fine. In fact the spice style guides say so. It was just
> a
> > mistake from my side.
> > 
> 
> So next question would be about:
> pixman_image_unref (mask); vs pixman_image_unref(mask); ???

Spice style rules says pixman_image_unref(mask), so that seems right.
I'm just used to the space from gnome code.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
       alexl at redhat.com            alexander.larsson at gmail.com 
He's a suave Jewish senator from a doomed world. She's a high-kicking bisexual 
magician's assistant from out of town. They fight crime! 



More information about the Spice-devel mailing list