[Spice-devel] [PATCH 03/30] Add line rasterizer

[Izik Eidus]

On 21 Feb 2010 10:15:07 +0100
Soeren Sandmann <sandmann at daimi.au.dk> wrote:

> Alexander Larsson <alexl at redhat.com> writes:
> 
> > On Fri, 2010-02-19 at 10:43 +0200, Izik Eidus wrote:
> > > On Thu, 18 Feb 2010 21:58:29 +0100
> > > Alexander Larsson <alexl at redhat.com> wrote:
> > > 
> > > > This is based on the X11 line drawers in mi/mizerline.c etc
> > > > ---
> > > >  client/Makefile.am     |    1 +
> > > >  client/lines.cpp       |   24 +
> > > >  client/x11/Makefile.am |    1 +
> > > >  common/Makefile.am     |    2 +
> > > >  common/lines.c         | 3632
> > > ++++++++++++++++++++++++++++++++++++++++++++++++
> > > 
> > > 
> > > Was lines.c was changed? and if yes can we somewhere doc what we
> > > changed in it?
> > 
> > yes, its a merge of various files from x with a bunch of small changes
> > to make it fit into spice and not require the whole X codebase. I have a
> > git tree that starts with the X files and does a lot of small changes to
> > it. It might be nice to have somewhere for later reference.
> > 
> > > And what will happen when x fix bugs in that code, how will we get it?
> > 
> > This is code from 1989, it has not changed significantly in many many
> > many years. I guess we might want to take a look at the x tree now and
> > then to see if there are any changes we want to pull in.
> 
> Or put it in pixman (eventually), so that both X and SPICE can use
> it. You are right though. This code doesn't really change, because
> essentially no one is using the core X primitives anymore.


Oh moving it into pixman make me feel much much better :-).

> 
> 
> Soren