[Spice-devel] [PATCH 20/30] Convert cairo canvas to use pixman for draw_stroke

[Alexander Larsson]

On Sat, 2010-02-20 at 10:33 +0200, Izik Eidus wrote:
> On Thu, 18 Feb 2010 21:58:46 +0100
> Alexander Larsson <alexl at redhat.com> wrote:

> > +    if (pixman_region32_n_rects (&gc.dest_region) == 0 ||
> > +        stroke->brush.type == SPICE_BRUSH_TYPE_NONE) {
> > +        touch_brush (canvas, &stroke->brush);
> > +        pixman_region32_fini (&gc.dest_region);
> > +        return;
> > +    }
> > 
> 
> That line is think is wrong beacuse we can get:
> SPICE_ROPD_OP_INVERS and therefore we dont need any brush.

Yeah, you're right. I really only added this to protect against problems
later where we don't handle TYPE_NONE in the switch. I think I'm gonna
pretend none means solid black brush to make this work with the invert
rops, etc.