[Spice-devel] [Spice-commits] 6 commits - client/red_channel.cpp client/red_client.cpp client/tunnel_channel.cpp common/messages.h python_modules/demarshal.py python_modules/marshal.py python_modules/ptypes.py python_modules/spice_parser.py server/reds.c server/red_tunnel_worker.c spice1.proto spice.proto

[Yaniv Kaul]

On 2010-07-20 09:51, Alon Levy wrote:
> ----- "Yaniv Kaul"<ykaul at redhat.com>  wrote:
>
>    
>> On 2010-07-19 17:48, Yaniv Kaul wrote:
>>      
>>> I can't compile spice now:
>>>
>>> cc1plus: warnings being treated as errors
>>> ../../client/generated_demarshallers.cpp: In function ‘uint8_t*
>>> parse_msg_display_copy_bits(uint8_t*, uint8_t*, int, size_t*, void
>>> (**)(uint8_t*))’:
>>> ../../client/generated_demarshallers.cpp:1223: error:
>>> ‘rects__saved_size’ may be used uninitialized in this function
>>>        
>>
>> [ykaul at ykaul spice]$ git bisect good
>> 38809803807637336209a89822e12bb5f22148ca is the first bad commit
>> commit 38809803807637336209a89822e12bb5f22148ca
>> Author: Alexander Larsson<alexl at redhat.com>
>> Date:   Mon Jul 19 15:48:20 2010 +0200
>>
>>       Send Clip.rects inline rather than using a pointer
>>
>> :100644 100644 fbafd829712f7ce71d375077d8730210103b1024
>> f24445b0ca60a6f8b54713d8cdcda7f81d3bafc3 M    spice.proto
>>
>>
>>      
>
> Alex fixed this meanwhile - Just compiled successfully from:
>    

Confirmed - although I had to manually delete some of the generated 
files - which I expect 'make clean' to have done.
Y.

> commit 74b470eeded366115b0c660288eccdf2f5291336
> Author: Alexander Larsson<alexl at redhat.com>
> Date:   Mon Jul 19 20:24:25 2010 +0200
>
>      Fix uninitialized variable warnings
>
>
> Alon
>