[Spice-devel] [PATCH 03/18] zap CoreInterface->next()
Gerd Hoffmann
kraxel at redhat.com
Mon Mar 29 08:08:39 PDT 2010
Interfaces must be registered after spice_server_init().
The "next" callback is used to discover interfaces
registered before spice_server_init(). Which is a empty
list and thus pretty pointless. Remove it.
---
server/reds.c | 7 -------
server/vd_interface.h | 2 --
2 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 59f97be..09234c8 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -4990,8 +4990,6 @@ const char *version_string = VERSION;
static void do_spice_init(CoreInterface *core_interface)
{
- VDInterface *interface = NULL;
-
red_printf("starting %s", version_string);
if (core_interface->base.base_version != VM_INTERFACE_VERSION) {
@@ -5021,11 +5019,6 @@ static void do_spice_init(CoreInterface *core_interface)
red_error("key modifiers timer create failed");
}
- if (core->next) {
- while ((interface = core->next(core, interface))) {
- interface_change_notifier(&reds, interface, VD_INTERFACE_ADDING);
- }
- }
if (core->register_change_notifiers) {
core->register_change_notifiers(core, &reds, interface_change_notifier);
}
diff --git a/server/vd_interface.h b/server/vd_interface.h
index 674fae0..42a011c 100644
--- a/server/vd_interface.h
+++ b/server/vd_interface.h
@@ -71,8 +71,6 @@ typedef void (*timer_callback_t)(void *opaque);
struct CoreInterface {
VDInterface base;
- VDInterface *(*next)(CoreInterface *core, VDInterface *prev);
-
VDObjectRef (*register_change_notifiers)(CoreInterface *core, void *opaque,
vd_interface_change_notifier_t in_notifier);
void (*unregister_change_notifiers)(CoreInterface *core, VDObjectRef notifier);
--
1.6.6.1
More information about the Spice-devel
mailing list