[Spice-devel] [PATCH 03/35] zap CoreInterface->next()

[Gerd Hoffmann]

Interfaces must be registered after spice_server_init().
The "next" callback is used to discover interfaces
registered before spice_server_init().  Which is a empty
list and thus pretty pointless.  Remove it.
---
 server/reds.c         |    7 -------
 server/vd_interface.h |    2 --
 2 files changed, 0 insertions(+), 9 deletions(-)

diff --git a/server/reds.c b/server/reds.c
index 9fc7a16..f62a127 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -4958,8 +4958,6 @@ const char *version_string = VERSION;
 
 static void do_spice_init(CoreInterface *core_interface)
 {
-    VDInterface *interface = NULL;
-
     red_printf("starting %s", version_string);
 
     if (core_interface->base.base_version != VM_INTERFACE_VERSION) {
@@ -4989,11 +4987,6 @@ static void do_spice_init(CoreInterface *core_interface)
         red_error("key modifiers timer create failed");
     }
 
-    if (core->next) {
-        while ((interface = core->next(core, interface))) {
-            interface_change_notifier(&reds, interface, VD_INTERFACE_ADDING);
-        }
-    }
     if (core->register_change_notifiers) {
         core->register_change_notifiers(core, &reds, interface_change_notifier);
     }
diff --git a/server/vd_interface.h b/server/vd_interface.h
index e91539f..35d006b 100644
--- a/server/vd_interface.h
+++ b/server/vd_interface.h
@@ -71,8 +71,6 @@ typedef void (*timer_callback_t)(void *opaque);
 struct CoreInterface {
     VDInterface base;
 
-    VDInterface *(*next)(CoreInterface *core, VDInterface *prev);
-
     VDObjectRef (*register_change_notifiers)(CoreInterface *core, void *opaque,
                                              vd_interface_change_notifier_t in_notifier);
     void (*unregister_change_notifiers)(CoreInterface *core, VDObjectRef notifier);
-- 
1.6.6.1