[Spice-devel] [PATCH 00/35] new libspice-server API patches.

[Alexander Larsson]

On Wed, 2010-05-12 at 13:31 +0200, Gerd Hoffmann wrote:
> Hi,
> 
> Ok folks, here is what I have right now for review.  The first patches
> of the patch series has been posted already a while back.  Now the
> remaining issues have been addressed.  Well, almost.  Client migration
> is not solved yet.
> 
> Most of the patches are pretty straight forward.  A more careful review
> is needed for the last six patches (30+).  30+31 are about savevm/loadvm
> support for the qxl device.  32-35 are about client migration.

I reviewed the patches up to 31. Some minor issues were pointed out in
separate mails, but generally i think this looks good and should go in
now.

There are still some old references that we should try to get rid of:

vd_interface.h should be renamed. Maybe spice_interfaces.h?

Are these needed:
#define VM_INTERFACE_VERSION 1
typedef unsigned long VDObjectRef;
#define INVALID_VD_OBJECT_REF 0

typedef enum {
    VD_LOG_ERROR = 1,
    VD_LOG_WARN,
    VD_LOG_INFO,
} LogLevel;
should be SPICE_LOG_foo?

typedef struct DrawArea {
This should probably be QxlDrawArea, since its a public header.


Do we need any of:

enum VDIArgType{
typedef struct VDIArgDescriptor {
typedef struct VDICmdArg {
typedef void (*VDICmdHandler)(const VDICmdArg* args);
typedef void (*VDIInfoCmdHandler)(void);


This seem to still not be converted to the new world:

VDObjectRef (*register_route_packet)(NetWireInterface *vlan,
net_wire_packet_route_proc_t proc,
                                         void *opaque);

> The patches 32-35 are largely untested and I'm not sure yet we'll really
> want to go into that direction.  So we might commit only patches 1-31
> for now and wait with the client migration bits.  Comments are welcome
> nevertheless.

I have not looked at these yet, but given your comments above, lets land
the other parts first and move to the new qemu. Then we could put these
on a new branch.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
       alexl at redhat.com            alexander.larsson at gmail.com 
He's an underprivileged devious jungle king with no name. She's a warm-hearted 
streetsmart magician's assistant from a family of eight older brothers. They 
fight crime!