[Spice-devel] [PATCH 00/35] new libspice-server API patches.

[Alexander Larsson]

On Mon, 2010-05-17 at 20:59 +0200, Gerd Hoffmann wrote:
> Hi,
> 
> > I reviewed the patches up to 31. Some minor issues were pointed out in
> > separate mails, but generally i think this looks good and should go in
> > now.
> 
> Yes, I agree on it.  Sort the remaining minor bits, then merge.
> 
> > There are still some old references that we should try to get rid of:
> >
> > vd_interface.h should be renamed. Maybe spice_interfaces.h?
> 
> Is there any reason to keep it separate from spice.h?  If not, then let 
> us just move over all content (after a cleanup pass).

Sounds good to me.

> > Are these needed:
> > #define VM_INTERFACE_VERSION 1
> > typedef unsigned long VDObjectRef;
> > #define INVALID_VD_OBJECT_REF 0
> 
> Can go away I think.
> 
> > typedef enum {
> >      VD_LOG_ERROR = 1,
> >      VD_LOG_WARN,
> >      VD_LOG_INFO,
> > } LogLevel;
> > should be SPICE_LOG_foo?
> 
> Looks like it isn't used anywhere.  Just drop?

I think you deleted the uses of it in:
http://lists.freedesktop.org/archives/spice-devel/2010-May/000341.html

> > typedef struct DrawArea {
> > This should probably be QxlDrawArea, since its a public header.
> 
> Yes.
> 
> > enum VDIArgType{
> > typedef struct VDIArgDescriptor {
> > typedef struct VDICmdArg {
> > typedef void (*VDICmdHandler)(const VDICmdArg* args);
> > typedef void (*VDIInfoCmdHandler)(void);
> 
> Not sure what they are used for.  Either drop or move to a private 
> header file I'd guess, but needs investigation.

Was used in:
http://lists.freedesktop.org/archives/spice-devel/2010-May/000365.html

So, just drop.