[Spice-devel] RFC: client: don't invalidate unless primary surface

[Alon Levy]

ok, want me to add it and send a patch? this makes sense?


----- "Alexander Larsson" <alexl at redhat.com> wrote:

> On Sun, 2010-05-23 at 14:40 -0400, Alon Levy wrote:
> > Izik suggested this, said it will save some performance - in bitmap
> > operations on non primary surfaces no need to invalidate the
> > rectangle. Did some very minimal tests on windows xp guest. Can
> anyone
> > have a look?
> 
> Its true that you don't have to invalidate on offscreen surfaces, but
> your patch below misses the main one:
> 
> #define DRAW(type) {                                \
>     PRE_DRAW;                                       \
>     canvas->draw_##type(*type, message->size());    \
>     POST_DRAW;                                      \
>     invalidate(type->base.box, false);              \
> }
> 
> 
> 
> 
> -- 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>  Alexander Larsson                                            Red Hat,
> Inc 
>        alexl at redhat.com            alexander.larsson at gmail.com 
> He's a time-tossed moralistic astronaut who dotes on his loving old
> ma. She's 
> a high-kicking thirtysomething bodyguard looking for love in all the
> wrong 
> places. They fight crime!