[Spice-devel] [PATCH] build: make it silent

[Pavel Zhukov]

Hi, Marc-André.

I have cloned
"git://git.freedesktop.org/git/spice/qemu"
There are no this patch, as I see.
Thank you for info.

On Sat, 13 Nov 2010 15:06:54 +0100
  Marc-André Lureau <marcandre.lureau at gmail.com> wrote:
> Hi Pavel,
> 
> On Sat, Nov 13, 2010 at 5:19 AM, Pavel Zhukov <pavel at zhukoff.net> 
>wrote:
>> Hi all.
>>
>> Patch of qemu-spice help is below.  It add 'qxl' option to qemu 
>>--help
>> output. This output need for correct libvirtd work with qxl,
> 
> Indeed, I was hit by the same issue myself, but I noticed the latest
> patch submission to QEMU upstream already includes that fix:
> 
> http://lists.gnu.org/archive/html/qemu-devel/2010-11/msg00142.html
> 
> best regards
> 
>> diff --git a/qemu-options.hx b/qemu-options.hx
>> index 718d47a..29d7b9c 100644
>> --- a/qemu-options.hx
>> +++ b/qemu-options.hx
>> @@ -701,7 +701,7 @@ Rotate graphical output 90 deg left (only PXA 
>>LCD).
>>  ETEXI
>>
>>  DEF("vga", HAS_ARG, QEMU_OPTION_vga,
>> -    "-vga [std|cirrus|vmware|xenfb|none]\n"
>> +    "-vga [std|cirrus|vmware|xenfb|qxl|none]\n"
>>     "                select video card type\n", QEMU_ARCH_ALL)
>>  STEXI
>>  @item -vga @var{type}
>>
>> On Fri, 12 Nov 2010 20:17:00 +0100
>>  Hans de Goede <hdegoede at redhat.com> wrote:
>>>
>>> Hi,
>>>
>>> On 11/12/2010 01:38 PM, Marc-André Lureau wrote:
>>>>
>>>> This patch make it easier to spot warnings in compilation.  It 
>>>>should
>>>> work with older versions of automake that don't support silent 
>>>>rules.
>>>>
>>>
>>> I personally don't like this as I like seeing what cflags are used
>>> when compiling. But maybe others in the team do. So don't see this
>>> as a nack. It is more of a not an ack from me, but if someone else
>>> likes it...
>>>
>>> Regards,
>>>
>>> Hans
>>> _______________________________________________
>>> Spice-devel mailing list
>>> Spice-devel at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>>
>> --
>> Best Regards, Pavel
>> _______________________________________________
>> Spice-devel mailing list
>> Spice-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>>
> 
> 
> 
> -- 
> Marc-André Lureau

Best regards, Pavel