[Spice-devel] [PATCH xf86-video-qxl 2/3] Change default virtual size to 1920x1080

[Hans de Goede]

Hi,

On 10/01/2010 11:12 AM, Gerd Hoffmann wrote:
>   Hi,
>
>> if (pScrn->display->virtualX == 0&& pScrn->display->virtualY == 0) {
>> - pScrn->display->virtualX = 1024;
>> - pScrn->display->virtualY = 768;
>> + pScrn->display->virtualX = 1920;
>> + pScrn->display->virtualY = 1080;
>> }
>
> Again, shouldn't this better taken from the largest resolution in the qxl mode list?
>

A valid point, but what about the framebuffer size limit? AFAIK the
resolution list comes from the ROM, so likely in the future
it may contain higher resolutions, but we could still be dealing with
a card with an 8 MB framebuffer. Or is there some magic in qemu to
only show 16MB framebuffer modes in the list when there is a
16MB framebuffer ?

Regards,

Hans