[Spice-devel] [PATCH xf86-drv-qxl F14-branch] Don't access the qxl device when our vt is not focussed

Hans de Goede hdegoede at redhat.com
Fri Oct 15 07:36:13 PDT 2010


Hi,

On 10/12/2010 03:13 PM, Soeren Sandmann wrote:
> Hans de Goede<hdegoede at redhat.com>  writes:
>
>> Trying to do so causes the X-server to segfault as it has
>> dropped iopl permission, which is, erm, undesirable :)
>
> I don't think the function should be called in_vga_mode()
> anymore. Maybe just rename it to have_vt() or something like that -
> other than that, it looks good to me.
>

Thanks for the review, new version coming up.

Regards,

Hans


More information about the Spice-devel mailing list