[Spice-devel] [PATCH xf86-drv-qxl F14-branch 3/3] free qxl->uxe with regular free not xfree

[Hans de Goede]

Hi,

This fixes one of quite a few compiler warnings. I've taken a quick
look and these warnings also look like real issues to me:

This one is real, can happen a certain flow in the fallback case:
uxa-glyphs.c: In function 'uxa_glyphs':
uxa-glyphs.c:1025:6: warning: 'width' may be used uninitialized in this functio
uxa-glyphs.c:1025:13: warning: 'height' may be used uninitialized in this funct

Another real issue:
uxa-render.c: In function 'uxa_try_driver_composite':
uxa-render.c:1090:6: warning: 'xDst_copy' may be used uninitialized in this fun
uxa-render.c:1090:17: warning: 'yDst_copy' may be used uninitialized in this fu

Regards,

hans


On 10/15/2010 04:36 PM, Hans de Goede wrote:
> ---
>   src/qxl_driver.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/qxl_driver.c b/src/qxl_driver.c
> index 8d4a85b..1a20821 100644
> --- a/src/qxl_driver.c
> +++ b/src/qxl_driver.c
> @@ -1112,7 +1112,7 @@ setup_uxa (qxl_screen_t *qxl, ScreenPtr screen)
>       {
>   	xf86DrvMsg(scrn->scrnIndex, X_ERROR,
>   		   "UXA initialization failed\n");
> -	xfree(qxl->uxa);
> +	free(qxl->uxa);
>   	return FALSE;
>       }
>