[Spice-devel] [PATCH qemu-spice] spice-core: fix watching for write events

Alon Levy alevy at redhat.com
Sun Oct 17 03:15:49 PDT 2010


ACK then.

----- "Hans de Goede" <hdegoede at redhat.com> wrote:

> Hi,
> 
> Yes, together with uncommenting the read_from_vdi_agent call you
> commented
> (and put it in a loop, see comments) this fixes the guest hangs I was
> seeing when sending large amounts of data. Now I can copy and paste
> large images between a linux guest and a linux client without any
> issues.
> 
> Regards,
> 
> Hans
> 
> 
> On 10/17/2010 11:55 AM, Alon Levy wrote:
> > looks straight forward enough.. have you tested this?
> >
> > ----- "Hans de Goede"<hdegoede at redhat.com>  wrote:
> >
> >> ---
> >>   ui/spice-core.c |    2 +-
> >>   1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/ui/spice-core.c b/ui/spice-core.c
> >> index 813cc10..0a45723 100644
> >> --- a/ui/spice-core.c
> >> +++ b/ui/spice-core.c
> >> @@ -96,7 +96,7 @@ static void watch_update_mask(SpiceWatch *watch,
> int
> >> event_mask)
> >>           on_read = watch_read;
> >>       }
> >>       if (watch->event_mask&  SPICE_WATCH_EVENT_WRITE) {
> >> -        on_read = watch_write;
> >> +        on_write = watch_write;
> >>       }
> >>       qemu_set_fd_handler(watch->fd, on_read, on_write, watch);
> >>   }
> >> --
> >> 1.7.3.1
> >>
> >> _______________________________________________
> >> Spice-devel mailing list
> >> Spice-devel at lists.freedesktop.org
> >> http://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list