[Spice-devel] leaking drawables

[Soeren Sandmann]

Gerd Hoffmann <kraxel at redhat.com> writes:

>    Hi,
> 
> > This happens for several consecutive resource releases. Looking at what
> > actually gets released by the driver we see that the resources are freed
> > in the same order as they were release, its just that a chunk of
> > resources are missing here and there.
> 
> Try the attached patch.  I'm pretty sure qxl just overruns the release
> ring, making complete release lists disappear now and then.
> 
> Surprisingly the bits are quite old.  /me wonders how this bug managed
> to stay in the code base unnoticed *that* long.  Any chance older
> guest driver versions used to be more aggressive in emptying the
> release ring?

FWIW, the X11 driver has had (and still has) issues with running out
of memory, that I have never tracked down fully.

So far I have blamed it either on bugs in the driver or on the fact
that the X11 driver so far has had to send images for almost
everything it does.

But if the device doesn't free commands properly, that would explain
it, since potentially large images could be leaked.


Soren