[Spice-devel] [PATCH xf86-video-qxl] Make non default qxl modes available

[Gerd Hoffmann]

> +/* Modelines for modes which are known by the qxl device, but are not in the
> +   server default mode table (DMTModes). Idea copied from the vmware xorg
> +   driver (which is also MIT licensed), the modes were generated using gtf. */
> +#define MODEPREFIX NULL, NULL, NULL, 0, M_T_DRIVER
> +#define MODESUFFIX 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,FALSE,FALSE,0,NULL,0,0.0,0.0
> +static DisplayModeRec qxl_modes[] = {

Why hardcode this?  The qxl device provides a list of modes ...

Also note that with spice 0.6 the guest can create any resolution it 
wants, the list of modes is needed for spice 0.4 guests only because it 
can only pick one from the list due to the way mode switching works.  Of 
course 0.6 guests still can use the mode list as hint ...

cheers,
   Gerd