[Spice-devel] [PATCH 1/5] Fix crash when resetting pixman image transform

alexl at redhat.com alexl at redhat.com
Tue Sep 21 11:19:01 PDT 2010


From: Alexander Larsson <alexl at redhat.com>

Resetting the transform is done by setting it to the identity
transform, not passing in NULL. Passing in NULL causes a crash.
---
 common/canvas_base.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/common/canvas_base.c b/common/canvas_base.c
index bbb135d..acf9ae5 100644
--- a/common/canvas_base.c
+++ b/common/canvas_base.c
@@ -1751,7 +1751,8 @@ static pixman_image_t *canvas_scale_surface(pixman_image_t *src, const SpiceRect
                              0, 0, /* dst */
                              width, height);
 
-    pixman_image_set_transform(src, NULL);
+    pixman_transform_init_identity(&transform);
+    pixman_image_set_transform(src, &transform);
 
     return surface;
 }
-- 
1.7.2.2



More information about the Spice-devel mailing list