[Spice-devel] [PATCH 0.8 9/9] server: make sure we clear vdagent and update mouse mode on agent disconnect

[Alon Levy]

On Fri, Apr 01, 2011 at 05:13:09PM +0200, Hans de Goede wrote:
> The check this patch removes causes us to not set vdagent to NULL, nor
> update the mouse mode when the guest agent disconnects when no client is
> attached. Which leads to a non working mouse, and on agent reconnect a
> "spice_server_char_device_add_interface: vdagent already attached" message
> instead of a successful re-add of the agent interface .

Well, that's my patch. So the ASSERT gets turned to an if and then dropped.
I like you explanation better then mine. At least now I know who to blame for
my non working agent - me!

ACK.

> ---
>  server/reds.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/server/reds.c b/server/reds.c
> index b349d77..6c7df09 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@ -1112,9 +1112,6 @@ static void reds_agent_remove()
>          reds_reset_vdp();
>      }
>  
> -    if (!reds->agent_state.connected) {
> -        return;
> -    }
>      reds->agent_state.connected = 0;
>      vdagent = NULL;
>      reds_update_mouse_mode();
> -- 
> 1.7.4.2
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel