[Spice-devel] [PATCH] protocol: use packed-start/end to pack structures

[Christophe Fergeau]

On Mon, Apr 11, 2011 at 01:18:27PM +0200, Christophe Fergeau wrote:
> spice-protocol comes with 2 headers to handle structure packing,
> but controller_prot.h and foreign_menu_prot were both using their
> own preprocessor definitions to handle packing. It's better to have
> structure packing macros centralized since how it's done varies
> between compilers, so it may need to change over time.


This patch was supposed to come with a cover letter which I lost :(

Basically, I was saying in it that the ATTR_PACKED macros were different
than what packed-start.h does on non-linux platforms, and that I had no
idea whether the way it was previously done was intentional or not, nor
if changing it would break something or not. Since a change in struct
padding in spice-protocol would likely result in pretty bad breakage,
this patch has to be reviewed very carefully :)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20110411/71ae0d1c/attachment.pgp>