[Spice-devel] [PATCH 09/15] client: remove c++ wrappers

Uri Lublin uril at redhat.com
Thu Apr 21 10:06:45 PDT 2011


On 04/21/2011 02:53 PM, Christophe Fergeau wrote:
> client/ contains several .cpp file which only #include a .c file
> of the same name. This is unusual and seems to only be done to
> get C++ name mangling on the symbols defined in the C file.
> Now that all headers files in common/ use extern "C", these
> wrappers are no longer useful.
> ---
>   client/Makefile.am         |   12 ------------
>   client/canvas_utils.cpp    |   25 -------------------------
>   client/gdi_canvas.cpp      |   24 ------------------------
>   client/gl_canvas.cpp       |   20 --------------------
>   client/glc.cpp             |   20 --------------------
>   client/lines.cpp           |   24 ------------------------
>   client/lz.cpp              |   20 --------------------
>   client/marshaller.cpp      |   24 ------------------------
>   client/mem.cpp             |   24 ------------------------
>   client/pixman_utils.cpp    |   25 -------------------------
>   client/quic.cpp            |   20 --------------------
>   client/region.cpp          |   20 --------------------
>   client/rop3.cpp            |   20 --------------------
>   client/sw_canvas.cpp       |   24 ------------------------
>   client/windows/Makefile.am |   26 +++++++++++++-------------
>   client/x11/Makefile.am     |   24 ++++++++++++------------

This breaks windows build with VS.
You need to also modify client/windows/redc.vcproj


More information about the Spice-devel mailing list