[Spice-devel] [PATCH 7/9] common: add ring_get_length() for debugging purposes

[Alon Levy]

On Wed, Apr 27, 2011 at 05:53:34PM +0200, Christophe Fergeau wrote:
> On Wed, Apr 27, 2011 at 10:24:01AM -0400, Marc-André Lureau wrote:
> > > Do you mean it should be #ifdef'ed? or that it's better to add the
> > > equivalent of G_GNUC_UNUSED to the function definition to avoid the
> > > compiler
> > > warning?
> > 
> > Is there such warning? I was expecting unused inline functions not to produce warning.
> > The ifdef shouldn't be necessary. It's just one more functions, similar to the other provided in ring.h
> 
> Not sure we get such a warning with the default spice cflags, but it's easy
> to get gcc to warn about such "dead" code (unused static functions)

gcc 4.6.0 by default warns about it, and if we have -Werror it should fail.

> 
> Christophe



> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel