[Spice-devel] [PATCH 2/3] spice: don't call displaystate callbacks from spice server context.

[Alon Levy]

On Thu, Apr 28, 2011 at 01:16:17PM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> >>+    if (ssd->cursor) {
> >>+        ssd->ds->cursor_define(ssd->cursor);
> >>+        cursor_put(ssd->cursor);
> >
> >So now we will only do cursor_put once per qemu_spice_display_refresh? This
> >changes the behavior - we will lose some cursor updates.
> 
> Correct.
> 
> >Not sure we care - the last one will still always be set (once display_refresh
> >is called).
> 
> dispaly_refresh is called at 30 Hz rate.  If the cursor changes at a
> higher rate your eyes will have a hard time following that anyway.
> Thus I don't see a problem here ...

I wasn't talking about user experience, just about correctness. Anyway, I agree
it isn't a problem, like I said.

> 
> cheers,
>   Gerd
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel