[Spice-devel] [PATCH v2 1/2] qxl: send interrupt after migration in case ram->int_pending != 0, RHBZ #732949
Gerd Hoffmann
kraxel at redhat.com
Wed Aug 31 05:42:54 PDT 2011
On 08/31/11 14:37, Yonit Halperin wrote:
> if qxl_send_events was called from spice server context, and then
> migration had completed before a call to pipe_read, the target
> guest qxl driver didn't get the interrupt. In addition,
> qxl_send_events ignored further interrupts of the same kind, since
> ram->int_pending was set. As a result, the guest driver was stacked
> or very slow (when the waiting for the interrupt was with timeout).
Looks fine except for this:
=== checkpatch complains ===
WARNING: line over 80 characters
#22: FILE: hw/qxl.c:1468:
+ * migration ended, qxl_set_irq for these events might not have
been called
cheers,
Gerd
PS: /me suggests to check out
http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html
More information about the Spice-devel
mailing list