[Spice-devel] [PATCH spice-gtk 3/6] spice-channel: replace the xmit buf by a queue of SpiceOutMsg-s

Marc-André Lureau marcandre.lureau at gmail.com
Fri Dec 2 08:44:38 PST 2011


On Thu, Dec 1, 2011 at 4:48 PM, Hans de Goede <hdegoede at redhat.com> wrote:
> +    if (buffered) {
> +        spice_msg_out_ref(out);
> +        g_queue_push_tail(&c->xmit_queue, out);

Have you actually checked that the msg is not modified/reused by any
of the callers?

Instead of adding a reference, we should take ownership of the msg,
that would be more obvious that it's not supposed to be touched once
you call the send function.

Marc-André Lureau

More information about the Spice-devel mailing list