[Spice-devel] [PATCH spice-gtk 10/11] Ignore the first mouse click when taking the grab

[Hans de Goede]

Hi,

On 12/09/2011 10:55 AM, Marc-André Lureau wrote:
> hi
>
> On Thu, Dec 8, 2011 at 4:38 PM, Hans de Goede <hdegoede at redhat.com <mailto:hdegoede at redhat.com>> wrote:
>
>     Hmm, this pointer ungrab seems weird, as soon as mouse_mode changes
>     to something other then SERVER, which can only happen in mouse_update(),
>     we do a try_mouse_ungrab, which already does a gdk_pointer_ungrab(),
>     so I believe that this bit can go away, or it should be under the
>
>
> That was a quick and reasonable way of supporting drag-n-drop between displays.
>
> It works well in client mode. It is needed, because by default, X (and other window system) do a pointer grab when you press a button, so that the release event is received by the same window regardless of where the pointer is. Here, we change that behaviour, so that you can press and release in two differents displays. This is only supported in client mouse mode.
>
> Hope that helps clear it

Yes it does, I think we should copy and paste most of your reply to a comment in the
code though, so it will still be clear to people exactly why this is done in
a couple of months / years.

So will you, or shall I?

Regards,

Hans