[Spice-devel] spice-gtk mouse notes

[Hans de Goede]

Hi,

On 12/09/2011 02:40 PM, Marc-André Lureau wrote:
> Hi
>
> On Thu, Dec 8, 2011 at 4:48 PM, Hans de Goede <hdegoede at redhat.com <mailto:hdegoede at redhat.com>> wrote:
>
>     * When switching from client to server mode (do killall spice-vdagent in a
>
>       linux guest), 2 things stand out:
>       1) The guest mouse cursor does not drawn until a mouse event happens, so the
>          usual showing of 2 mouse cursors when the mouse is not grabbed does not
>          happen, which is confusing (the showing of 2 mouse cursors helps to explain
>          that the guest cursor is frozen until a mouse grab happens)
>
>
> I am not surprised there is issues in this case, as I haven't played with mode switching yet.

I see that you've fixed this in your new series, good!


>
>       2) The mouse does not get grabbed immediately even though
>     "grab mouse in server mode" is enabled. After a click the mouse does get
>          grabbed (but the guest cursor still does not get drawn until a mouse event
>          which actually gets send to the guest is generated).
>
>
> It can't grab immediately, as you may not be using your spice client, and you don't want to steal the pointer from the user. Perhaps we could do it when we have the pointer & focus?

Ah, yes that sounds like a good idea (doing it, but only when we've pointer & focus).

>
>     * When pressing SHIFT+F12 to ungrab both the SHIFT and the F12 key events also
>       get send to the guest (the SHIFT one is unavoidable, but IMHO we should not send
>       the F12 events), this happens both with and without having keyboard grabbing
>       enabled.
>
>
> The nice thing about sending it to the guest too, is that you don't prevent the user from using that key combination in the guest. Which is actually very helpful when using spicy inside spicy, for instance. Fixing this is trivial if we really prefer that behaviour.

I think we should fix it, currently this behavior leads to sending ";2~" to the
commandline (bash) / whatever text document one has open inside an editor inside
an xterm / gnome-terminal / foo-term, when ever one tries to ungrab the cursor.

Regards,

Hans