[Spice-devel] [PATCH spice-gtk 1/9] spice-channel: cleanup, get rid of wait_interruptible variable

Hans de Goede hdegoede at redhat.com
Thu Dec 15 04:30:01 PST 2011


On 12/14/2011 05:49 PM, Marc-André Lureau wrote:
> Hi guys,
> Hans, this is a similar patch series I already reviewed positively,

Correct, but you wanted me to change it so that
spice_msg_out[_send_internal] would take ownership of the passed SpiceMsgOut,
hence the new revision. Sorry I should have added an introductory message
to the set explaining this.

So effectively the following patches need (re)-review:

2/9: smartcard_message_complete_in_flight cleanup error checking
4/9: spice_msg_out[_send_internal]: Take ownership of the passed SpiceMsgOut
6/9: spice-channel: replace the xmit buf by a queue of SpiceOutMsg-s

Where 4/9 is new, and 6/9 no longer refs the message on queueing it and
unref's on de-queing. Instead it is queued with the passed in ref, and
unref-ed after it has actually been send.

> I would just prefer Christophe reviewed the smartcard changes,

Christophe already acked:
3/9: channel-smartcard: unref in flight messages as soon as they are send
But indeed his ack for:
2/9: smartcard_message_complete_in_flight cleanup error checking
and some testing would be very welcome.



More information about the Spice-devel mailing list