[Spice-devel] [PATCH] client: RedScreen::RedScreen: fix initialization order of _menu_needs_update
alevy at redhat.com
Thu Dec 22 01:29:22 PST 2011
On Thu, Dec 22, 2011 at 11:23:48AM +0200, Uri Lublin wrote:
> On 12/22/2011 11:11 AM, Christophe Fergeau wrote:
> > What do you mean exactly by "fix"? Just that it's better to put field
> > initialization in the order it will actually happen? Or something else?
> The compiler warns about it.
> When the compiler is requested to handle warnings as error (and we do),
> build fails.
It broke jenkins. (the email is not sent to the list right now, just to
me - should be sent to the author of the breaking commit(s)).
> > On Thu, Dec 22, 2011 at 10:54:57AM +0200, Uri Lublin wrote:
> >> Related to a91b0b3ff712eb2a7d91a951f2af7842495357c3
> >> ---
> >> client/screen.cpp | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >> diff --git a/client/screen.cpp b/client/screen.cpp
> >> index 0b3ba6f..a0dc0df 100644
> >> --- a/client/screen.cpp
> >> +++ b/client/screen.cpp
> >> @@ -87,6 +87,7 @@ RedScreen::RedScreen(Application& owner, int id, const std::string& name, int wi
> >> , _key_interception (false)
> >> , _update_by_timer (true)
> >> , _size_locked (false)
> >> + , _menu_needs_update (false)
> >> , _forec_update_timer (0)
> > Can you change this to _force_update_timer while you're changing this part
> > of the code? Thanks!
> Sent a patch.
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
More information about the Spice-devel