[Spice-devel] [PATCH] Fix build from git with srcdir != builddir

Christophe Fergeau cfergeau at redhat.com
Thu Dec 22 06:53:09 PST 2011


On Thu, Dec 22, 2011 at 09:44:59AM -0500, Marc-André Lureau wrote:
> Outputting files in srcdir goes against the idea of out of tree build.

I know, I wish I could put them in build dir but that would break with
tarballs.

> Since .c are dist'ed, they should be in the srcdir, so in the end I think
> that patch isn't really useful.

Yup, it shouldn't change anything for tarballs, that's why the log talks
about builds from git

> 
> Instead, "./autogen.sh && make && make clean" should be run before doing
> out of tree builds from git.

Ugly workaround imo... (with s/clean/distclean)

I don't care at all anyway, let's drop this patch, just one more ugly thing
we'll have to live with...

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20111222/da5f9060/attachment.pgp>


More information about the Spice-devel mailing list