[Spice-devel] [PATCH spice-gtk 02/10] usbredir: Stop setting private data explictly to NULL on init

Christophe Fergeau cfergeau at redhat.com
Fri Dec 23 09:13:38 PST 2011


ACK

On Mon, Dec 19, 2011 at 12:24:35PM +0100, Hans de Goede wrote:
> This is not necessary and as we get more private data it becomes
> unyieldly.
> 
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> ---
>  gtk/usb-device-manager.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
> 
> diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
> index 313b6ab..ea43b75 100644
> --- a/gtk/usb-device-manager.c
> +++ b/gtk/usb-device-manager.c
> @@ -122,15 +122,9 @@ static void spice_usb_device_manager_init(SpiceUsbDeviceManager *self)
>      priv = SPICE_USB_DEVICE_MANAGER_GET_PRIVATE(self);
>      self->priv = priv;
>  
> -    priv->main_context = NULL;
>      priv->channels = g_ptr_array_new();
>      priv->devices  = g_ptr_array_new_with_free_func((GDestroyNotify)
>                                                      g_object_unref);
> -#ifdef USE_USBREDIR
> -    priv->context = NULL;
> -    priv->source  = NULL;
> -    priv->devlist = NULL;
> -#endif
>  }
>  
>  static gboolean spice_usb_device_manager_initable_init(GInitable  *initable,
> -- 
> 1.7.7.4
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20111223/5a4c895b/attachment.pgp>


More information about the Spice-devel mailing list