[Spice-devel] [PATCH spice-gtk 06/10] usbredir: Add locking callbacks for libusbredirhost

Marc-André Lureau marcandre.lureau at gmail.com
Wed Dec 28 04:14:31 PST 2011

On Mon, Dec 19, 2011 at 12:24 PM, Hans de Goede <hdegoede at redhat.com> wrote:

> +static void *usbredir_alloc_lock(void);
> +static void usbredir_lock_lock(void *user_data);
> +static void usbredir_unlock_lock(void *user_data);
> +static void usbredir_free_lock(void *user_data);
> +

Minor nitpicks, I think it would be a bit less verbose and more pleasant to
read if you would just use casts for calling glib flavours of mutexes.

Would there be drawbacks if the library would simply use the equivalent of
GStaticMutex instead?

Marc-André Lureau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20111228/be46469b/attachment.html>

More information about the Spice-devel mailing list