[Spice-devel] [PATCH 07/24] server/red_channel: make client ack window configurable

[Marc-André Lureau]

ack

On Wed, Jan 19, 2011 at 7:07 PM, Alon Levy <alevy at redhat.com> wrote:
> from red_worker
> ---
>  server/red_channel.c |    6 ++++--
>  server/red_channel.h |    1 +
>  2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/server/red_channel.c b/server/red_channel.c
> index c13d972..9b25f0a 100644
> --- a/server/red_channel.c
> +++ b/server/red_channel.c
> @@ -276,6 +276,7 @@ RedChannel *red_channel_create(int size, RedsStreamContext *peer,
>     channel->ack_data.messages_window = ~0;  // blocks send message (maybe use send_data.blocked +
>                                              // block flags)
>     channel->ack_data.client_generation = ~0;
> +    channel->ack_data.client_window = CLIENT_ACK_WINDOW;
>
>     channel->migrate = migrate;
>     ring_init(&channel->pipe);
> @@ -400,7 +401,7 @@ int red_channel_handle_message(RedChannel *channel, uint32_t size,
>         break;
>     case SPICE_MSGC_ACK:
>         if (channel->ack_data.client_generation == channel->ack_data.generation) {
> -            channel->ack_data.messages_window -= CLIENT_ACK_WINDOW;
> +            channel->ack_data.messages_window -= channel->ack_data.client_window;
>             red_channel_push(channel);
>         }
>         break;
> @@ -552,7 +553,8 @@ static PipeItem *red_channel_pipe_get(RedChannel *channel)
>     PipeItem *item;
>
>     if (!channel || channel->send_data.blocked ||
> -        (channel->handle_acks && (channel->ack_data.messages_window > CLIENT_ACK_WINDOW * 2)) ||
> +        (channel->handle_acks &&
> +         (channel->ack_data.messages_window > channel->ack_data.client_window * 2)) ||
>         !(item = (PipeItem *)ring_get_tail(&channel->pipe))) {
>         return NULL;
>     }
> diff --git a/server/red_channel.h b/server/red_channel.h
> index 0339559..08550a1 100644
> --- a/server/red_channel.h
> +++ b/server/red_channel.h
> @@ -123,6 +123,7 @@ struct RedChannel {
>         uint32_t generation;
>         uint32_t client_generation;
>         uint32_t messages_window;
> +        uint32_t client_window;
>     } ack_data;
>
>     Ring pipe;
> --
> 1.7.3.4
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>



-- 
Marc-André Lureau