[Spice-devel] [PATCH 12/24] server/red_channel: unstatic red_channel_pipe_clear (for red_worker)

Marc-André Lureau marcandre.lureau at gmail.com
Wed Feb 2 10:52:00 PST 2011


ack

On Wed, Jan 19, 2011 at 7:07 PM, Alon Levy <alevy at redhat.com> wrote:
> ---
>  server/red_channel.c |    3 +--
>  server/red_channel.h |    4 ++++
>  2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/server/red_channel.c b/server/red_channel.c
> index 2051228..bda5e81 100644
> --- a/server/red_channel.c
> +++ b/server/red_channel.c
> @@ -30,7 +30,6 @@
>  #include "red_channel.h"
>
>  static PipeItem *red_channel_pipe_get(RedChannel *channel);
> -static void red_channel_pipe_clear(RedChannel *channel);
>  static void red_channel_event(int fd, int event, void *data);
>
>  /* return the number of bytes read. -1 in case of error */
> @@ -576,7 +575,7 @@ int red_channel_is_connected(RedChannel *channel)
>     return !!channel->peer;
>  }
>
> -static void red_channel_pipe_clear(RedChannel *channel)
> +void red_channel_pipe_clear(RedChannel *channel)
>  {
>     PipeItem *item;
>     if (channel->send_data.item) {
> diff --git a/server/red_channel.h b/server/red_channel.h
> index 310db64..10c9a66 100644
> --- a/server/red_channel.h
> +++ b/server/red_channel.h
> @@ -230,5 +230,9 @@ void red_channel_pipe_add_type(RedChannel *channel, int pipe_item_type);
>  // should be that they ""try"" a little harder, but if the event system is correct it
>  // should not make any difference.
>  void red_channel_push(RedChannel *channel);
> +// TODO: again - what is the context exactly? this happens in channel disconnect. but our
> +// current red_channel_shutdown also closes the socket - is there a socket to close?
> +// are we reading from an fd here? arghh
> +void red_channel_pipe_clear(RedChannel *channel);
>
>  #endif
> --
> 1.7.3.4
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>



-- 
Marc-André Lureau


More information about the Spice-devel mailing list