[Spice-devel] [PATCH 21/24] server/red_channel: add TODO

[Marc-André Lureau]

ack

On Wed, Jan 19, 2011 at 7:08 PM, Alon Levy <alevy at redhat.com> wrote:
> ---
>  server/red_channel.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/server/red_channel.c b/server/red_channel.c
> index 7db02ab..9ad2e5a 100644
> --- a/server/red_channel.c
> +++ b/server/red_channel.c
> @@ -64,6 +64,10 @@ static int red_peer_receive(RedsStreamContext *peer, uint8_t *buf, uint32_t size
>     return pos - buf;
>  }
>
> +// TODO: this implementation, as opposed to the old implementation in red_worker,
> +// does many calls to red_peer_receive and through it cb_read, and thus avoids pointer
> +// arithmetic for the case where a single cb_read could return multiple messages. But
> +// this is suboptimal potentially. Profile and consider fixing.
>  static void red_peer_handle_incoming(RedsStreamContext *peer, IncomingHandler *handler)
>  {
>     int bytes_read;
> --
> 1.7.3.4
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>



-- 
Marc-André Lureau