[Spice-devel] [PATCH 23/24] server/red_channel: red_channel_pipe_clear: assert on NULL channel

[Marc-André Lureau]

ack

(I would prefer return_if_fail(channel != NULL) instead here)

On Wed, Jan 19, 2011 at 7:08 PM, Alon Levy <alevy at redhat.com> wrote:
> ---
>  server/red_channel.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/server/red_channel.c b/server/red_channel.c
> index 0eba73c..b621be9 100644
> --- a/server/red_channel.c
> +++ b/server/red_channel.c
> @@ -601,10 +601,11 @@ int red_channel_is_connected(RedChannel *channel)
>  void red_channel_pipe_clear(RedChannel *channel)
>  {
>     PipeItem *item;
> +
> +    ASSERT(channel);
>     if (channel->send_data.item) {
>         channel->release_item(channel, channel->send_data.item, TRUE);
>     }
> -

I liked that extra line too ;)

>     while ((item = (PipeItem *)ring_get_head(&channel->pipe))) {
>         ring_remove(&item->link);
>         channel->release_item(channel, item, FALSE);
> --
> 1.7.3.4
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>



-- 
Marc-André Lureau