[Spice-devel] [PATCH 19/26] server/red_channel: move free of SET_ACK pipe item to release

Marc-André Lureau marcandre.lureau at gmail.com
Mon Feb 14 17:29:13 PST 2011


Ok, it looks like it should be squashed with 21/23 from previous patch
series (see my comments there)

On Fri, Feb 11, 2011 at 6:49 PM, Alon Levy <alevy at redhat.com> wrote:
> ---
>  server/red_channel.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/server/red_channel.c b/server/red_channel.c
> index f570960..0921388 100644
> --- a/server/red_channel.c
> +++ b/server/red_channel.c
> @@ -276,7 +276,6 @@ static void red_channel_send_item(RedChannel *channel, PipeItem *item)
>     switch (item->type) {
>         case PIPE_ITEM_TYPE_SET_ACK:
>             red_channel_send_set_ack(channel);
> -            free(item);
>             return;
>     }
>     /* only reached if not handled here */
> @@ -287,6 +286,7 @@ static void red_channel_release_item(RedChannel *channel, PipeItem *item, int it
>  {
>     switch (item->type) {
>         case PIPE_ITEM_TYPE_SET_ACK:
> +            free(item);
>             return;
>     }
>     /* only reached if not handled here */
> --
> 1.7.4
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>



-- 
Marc-André Lureau


More information about the Spice-devel mailing list