[Spice-devel] [PATCH 01/13] server/reds: remove unused readv

Alon Levy alevy at redhat.com
Thu Feb 24 08:28:39 PST 2011


On Tue, Feb 22, 2011 at 05:08:55PM +0100, Marc-André Lureau wrote:
> Let's not bother with it since nobody uses it, and it's not implemented for SSL anyway

ACK (sorry for long time).

> ---
>  server/reds.c |    2 --
>  server/reds.h |    1 -
>  2 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/server/reds.c b/server/reds.c
> index 470a0e6..d92f701 100644
> --- a/server/reds.c
> +++ b/server/reds.c
> @@ -1899,7 +1899,6 @@ static RedLinkInfo *reds_accept_connection(int listen_socket)
>      peer->ctx = (void *)((unsigned long)link->peer->socket);
>      peer->cb_read = (int (*)(void *, void *, int))reds_read;
>      peer->cb_write = (int (*)(void *, void *, int))reds_write;
> -    peer->cb_readv = (int (*)(void *, const struct iovec *vector, int count))readv;
>      peer->cb_writev = (int (*)(void *, const struct iovec *vector, int count))writev;
>      peer->cb_free = (int (*)(RedsStreamContext *))reds_free;
>  
> @@ -1936,7 +1935,6 @@ static void reds_accept_ssl_connection(int fd, int event, void *data)
>      link->peer->ctx = (void *)(link->peer->ssl);
>      link->peer->cb_write = (int (*)(void *, void *, int))reds_ssl_write;
>      link->peer->cb_read = (int (*)(void *, void *, int))reds_ssl_read;
> -    link->peer->cb_readv = NULL;
>      link->peer->cb_writev = reds_ssl_writev;
>      link->peer->cb_free = (int (*)(RedsStreamContext *))reds_ssl_free;
>  
> diff --git a/server/reds.h b/server/reds.h
> index b5dec7e..547c33c 100644
> --- a/server/reds.h
> +++ b/server/reds.h
> @@ -44,7 +44,6 @@ typedef struct RedsStreamContext {
>      int (*cb_write)(void *, void *, int);
>      int (*cb_read)(void *, void *, int);
>  
> -    int (*cb_readv)(void *, const struct iovec *vector, int count);
>      int (*cb_writev)(void *, const struct iovec *vector, int count);
>      int (*cb_free)(struct RedsStreamContext *);
>  } RedsStreamContext;
> -- 
> 1.7.4
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list