[Spice-devel] [PATCH 02/13] server: use proper methods for Stream read/write()

[Marc-André Lureau]

Hi

On Thu, Feb 24, 2011 at 5:30 PM, Alon Levy <alevy at redhat.com> wrote:
> On Tue, Feb 22, 2011 at 05:08:56PM +0100, Marc-André Lureau wrote:
>> This allows easier modification of the underlying IO.
>>
>> We also avoid using the "generic ctx pointer"
>>
>> Also rename StreamContext for Stream, stylistic change (it's obviously
>> a context, no?).
>
> I'm really having a problem reviewing this one - it's got a number of changes
> going on at once. It seems to be good, but could you split it? renames aside,
> and actual contents (moving the event notification, I can't be sure it still happens
> at the correct points). Also not sure if all the renames are good (removing the cb_
> prefix? I don't care one way or the other, but seems like just churn).

You are right, it could be splitted further. Regarding cb_ prefix,
hmm, true, it's churn (but that way I was sure no code was left using
it - that's why I changed it in the first place)

regards

-- 
Marc-André Lureau