[Spice-devel] [PATCH] Revert "server: remove dep on libcacard"

[Alon Levy]

On Mon, Jan 24, 2011 at 03:36:23PM +0200, Alon Levy wrote:
> This reverts commit 9c0db1c6c310c758c01e0452dd2dd092d9377fc9.
> 
> My bad - server doesn't link with libcacard but depends on a header
> that is provided by it, vscard_common.h, where the protocol is defined.
> 

Double bad - NACK myself.

Dependence is during compile, not for linkers to spice-server - so we
only need a BuildRequires, but that's it.

> The server does look at the packets, just doesn't use the virtual card.
> ---
>  configure.ac |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 9159b4a..a17a43a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -193,6 +193,7 @@ if test "x$have_smartcard" = "xyes"; then
>      PKG_CHECK_MODULES(CAC_CARD, libcacard >= 0.1.0)
>      SMARTCARD_LIBS="$CAC_CARD_LIBS"
>      SMARTCARD_CFLAGS="$CAC_CARD_CFLAGS"
> +    SPICE_REQUIRES+=" libcacard"
>      AC_SUBST(SMARTCARD_LIBS)
>      AC_SUBST(SMARTCARD_CFLAGS)
>  fi
> -- 
> 1.7.3.5
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel