[Spice-devel] [PATCH] client/application: fix missing smartchannel in set_channel_security

[Alon Levy]

On Tue, Jan 25, 2011 at 03:40:06PM +0100, Hans de Goede wrote:
> Hi,
> 
> On 01/25/2011 03:06 PM, Alon Levy wrote:
> >---
> >  client/application.cpp |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> >
> >diff --git a/client/application.cpp b/client/application.cpp
> >index d865e84..d0da277 100644
> >--- a/client/application.cpp
> >+++ b/client/application.cpp
> >@@ -1914,6 +1914,9 @@ bool Application::set_channels_security(CmdLineParser&  parser, bool on, char *va
> >      channels_names["playback"] = SPICE_CHANNEL_PLAYBACK;
> >      channels_names["record"] = SPICE_CHANNEL_RECORD;
> >      channels_names["tunnel"] = SPICE_CHANNEL_TUNNEL;
> >+#ifdef USE_SMARTCARD
> >+    channels_names["smartcard"] = SPICE_CHANNEL_SMARTCARD;
> >+#endif
> >
> >      if (!strcmp(val, "all")) {
> >          if ((val = parser.next_argument())) {
> 
> The same is needed for Application::set_enable_channels() and for
> server/reds.c: spice_server_set_channel_security()
> 
NACK this patch, sent an updated one, and another for adding USE_TUNNEL
protection to same code for tunnel channel.

> Regards,
> 
> Hans