[Spice-devel] [PATCH 3/9] common/sw_canvas: remove unused error val

Alon Levy alevy at redhat.com
Tue Jan 25 07:33:59 PST 2011


This is the only unused var change I'll want to revisit eventually,
I'm submitting anyway since it doesn't change current behavior. I'm
talking about ignoring the return value from canvas creation. Adding
a print is possible but I didn't test (may be too verbose, also
preferable to be a debug print if so, and we don't have that option
in the code atm - probably an environment variable will do, or adding
some spice_server_set_logging_level api, maybe even
spice_server_set_logging_fd?)
---
 common/sw_canvas.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/common/sw_canvas.c b/common/sw_canvas.c
index 37083df..f17bc58 100644
--- a/common/sw_canvas.c
+++ b/common/sw_canvas.c
@@ -1180,7 +1180,6 @@ static SpiceCanvas *canvas_create_common(pixman_image_t *image,
                            )
 {
     SwCanvas *canvas;
-    int init_ok;
 
     if (need_init) {
         return NULL;
@@ -1189,7 +1188,7 @@ static SpiceCanvas *canvas_create_common(pixman_image_t *image,
                                   spice_surface_format_to_pixman (format));
 
     canvas = spice_new0(SwCanvas, 1);
-    init_ok = canvas_base_init(&canvas->base, &sw_canvas_ops,
+    canvas_base_init(&canvas->base, &sw_canvas_ops,
                                pixman_image_get_width (image),
                                pixman_image_get_height (image),
                                format
-- 
1.7.3.5



More information about the Spice-devel mailing list