[Spice-devel] [RFC] client: --help should not need X

Alon Levy alevy at redhat.com
Wed Jan 26 01:20:11 PST 2011


On Wed, Jan 26, 2011 at 11:12:41AM +0200, Uri Lublin wrote:
> On 01/26/2011 01:55 AM, Alon Levy wrote:
> >separate initialization into before command line parsing and after,
> >call later only if command line parsing succeeds (in particular, it
> >"fails" if --help is given).
> >
> 
> Good. This one has been waiting for someone to fix for quite some time.
> 
> >---
> >  client/application.cpp |   75 ++++++++++++++++++++++++++++++++---------------
> >  client/application.h   |    3 ++
> >  2 files changed, 54 insertions(+), 24 deletions(-)
> >
> >diff --git a/client/application.cpp b/client/application.cpp
> >index d1aef1a..eff0495 100644
> >--- a/client/application.cpp
> >+++ b/client/application.cpp
> 
> 
> >+
> >+void Application::cleanup_platform_globals()
> 
> Does this function ever get called ?
> 
Nope, will fix.

> >  {
> >      RedWindow::cleanup();
> >  }
> >
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list