[Spice-devel] [PATCH 0/3] client: fix --help behavior and msvc build

Alon Levy alevy at redhat.com
Thu Jan 27 02:45:26 PST 2011


First patch splits initilization of client to before parsing and after parsing
of command line arguments. fixed calling of cleanup per Uri's comment.

Second patch fixes Msvc 2008 build that has been broken since mingw patches
were pushed.

Third patch makes windows client not allocate a console if it's parent process
has one, like running from cmd.exe. There is a comment in there that explains
that to actually capture the output in that case you need to do:
 cmd /c spicec.exe > captured_output
because cmd.exe apparently notices spicec is a windows subsystem executable
and backgrounds it, and on top of that start /wait causes failed calls to
_open_osfhandle (now protected by ifs).

Alon Levy (3):
  client: --help should not need platform initialization
  client: fix broken vs2008 build
  client/windows: don't allocate console unless required

 client/application.cpp      |   92 +++++++++++++++++++++++++++----------------
 client/application.h        |    5 ++-
 client/common.h             |   11 +++++-
 client/process_loop.cpp     |    2 +-
 client/red_client.cpp       |    4 ++
 client/windows/platform.cpp |   36 +++++++++++++----
 6 files changed, 104 insertions(+), 46 deletions(-)

-- 
1.7.3.5



More information about the Spice-devel mailing list