[Spice-devel] [PATCH 2/3] spice-channel: add property total-bytes-read

Marc-André Lureau mlureau at redhat.com
Mon Jul 4 02:55:03 PDT 2011


Hi

----- Original Message -----
> On Sat, Jul 02, 2011 at 05:06:39AM +0200, Alon Levy wrote:
> > --- a/gtk/spice-channel-priv.h
> > +++ b/gtk/spice-channel-priv.h
> > @@ -123,6 +123,8 @@ struct spice_channel {
> >      GArray *common_caps;
> >      GArray *remote_caps;
> >      GArray *remote_common_caps;
> > +
> > + gsize total_read_bytes;
> 
> sizeof(gsize) is 8 on 64 bit machines...

 unsigned long gsize;

(this is partly my fault..)

> 
> > @@ -288,6 +292,15 @@ static void
> > spice_channel_class_init(SpiceChannelClass *klass)
> >                            G_PARAM_STATIC_NICK |
> >                            G_PARAM_STATIC_BLURB));
> >
> > + g_object_class_install_property
> > + (gobject_class, PROP_TOTAL_READ_BYTES,
> > + g_param_spec_uint("total-read-bytes",
> 
> ...so this should be an uint64 property

or a ulong property.

fixed upstream.

-- 
Marc-André Lureau


More information about the Spice-devel mailing list