[Spice-devel] [PATCH v3] server: add QXLInterface::surface_updated callback

[Alon Levy]

On Fri, Jul 08, 2011 at 10:05:19AM +0200, Gerd Hoffmann wrote:
> On 07/08/11 09:47, Alon Levy wrote:
> >On Fri, Jul 08, 2011 at 08:41:22AM +0200, Gerd Hoffmann wrote:
> >>On 07/07/11 18:33, Alon Levy wrote:
> >>>This is RfC quality. Specifically where to call surface_updated. Currently I
> >>>only call it from stop. This should be good enough for migration, which is
> >>>the only use case I think. This means after stop qemu is guranteed to know
> >>>the dirty regions of all surfaces.
> >>
> >>The other use case is local rendering when using qxl with vnc.  qemu
> >>calls update_area for the primary surface then, and passes on the
> >>updated rectangles so the vnc server will send the updates to the
> >>client.  When moving this to the async interface by calling
> >>update_area_async instead it I'll need surface_update calling me
> >>back when the renderer is done.
> >
> >ok, I'll add this. Is an additional patch good?
> 
> Fine with me.
> 
> BTW: wasn't the plan to remove the rect args from update_area_async?

I thought the idea was just to remove the dirty rects, not the actual
rect the guest wants updated. This patch removes the former.

> 
> cheers,
>   Gerd
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel