[Spice-devel] [PATCH v6 2/9] server: api: add spice_qxl_* calls based on QXLWorker contents

[Gerd Hoffmann]

> Ok, I'd have gone with using these to implement spice_qxl_wakeup et al:
> void spice_qxl_wakeup(QXLInstance *instance)
> {
>      QXLWorker *worker = (QXLWorker *)instance->st->dispatcher;

QXLWorker *worker = &instance->st->dispatcher->base;

avoids the cast.

>      ASSERT(worker->wakeup != NULL)
>      worker->wakeup(worker);
> }
>
> or something like that
>
> But maybe that's something kraxel wanted to avoid.

Would work too.  Although the code is more consistent the way alon did 
it as the new spice_qxl_*_async() calls added a few patches later don't 
get a worker function pointer.

cheers,
   Gerd