[Spice-devel] [PATCH 1/2] client: only send one SPICE_MSGC_MAIN_ATTACH_CHANNELS messages

[Christophe Fergeau]

On Thu, Jul 21, 2011 at 07:02:48PM +0300, Alon Levy wrote:
> On Thu, Jul 21, 2011 at 05:43:16PM +0200, Christophe Fergeau wrote:
> > 492f7a9b fixed unwanted timeouts during initial client startup,
> > but it also caused a bad regression when connecting to
> > RHEL6+agent guests: the SPICE_MSGS_MAIN_ATTACH_CHANNELS message
> > was sent multiple times, once in RedClient::handle_init, then
> > once again in RedClient::on_agent_announce_capabilities (which
> > can even be triggered multiple times). Sending this message multiple
> > times is a big NO and causes the server to close the client connection,
> > and the client to die. Add a _msg_attach_message_sent boolean to
> > make sure we only send this message once.
> 
> ACK.

Thanks, pushed.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20110722/c5b93073/attachment.pgp>