[Spice-devel] [PATCH vdagent-win 6/6] vdagent: add casting

Christophe Fergeau cfergeau at redhat.com
Mon Jul 25 01:21:32 PDT 2011


Hi Arnon,

On Sun, Jul 24, 2011 at 01:48:18PM +0300, Arnon Gilboa wrote:
> ---
>  vdagent/desktop_layout.cpp |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/vdagent/desktop_layout.cpp b/vdagent/desktop_layout.cpp
> index 9bd1852..0eada52 100644
> --- a/vdagent/desktop_layout.cpp
> +++ b/vdagent/desktop_layout.cpp
> @@ -67,7 +67,7 @@ void DesktopLayout::get_displays()
>          }
>          size_t size = _displays.size();
>          if (!wcsstr(dev_info.DeviceString, L"QXL")) {
> -            display_id = size;
> +            display_id = (DWORD)size;

If you haven't pushed yet, can you add one line in the commit log
explaining why you do it? Ie if it's fixing a bug (something getting
truncated/badly converted/... without the cast), or if it's fixing a
compiler warning, or if you're doing the change for another reason.

Thanks,

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20110725/fa919f26/attachment.pgp>


More information about the Spice-devel mailing list